gui: Move package to internal. #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
internal_gui
branch
2 times, most recently
from
b69006e
to
6980a38
Compare
jholdstock
requested changes
Sep 13, 2023
dcrpool is an application and thus all of its package not intended for external consumers should not be publicly visible. To that end, this moves the gui package to an internal package meaning that it is no longer a part of the exported main module.
Thanks, updated. As an aside, this should really be changed over to use |
davecgh
force-pushed
the
internal_gui
branch
from
6980a38
to
e8557f2
Compare
jholdstock
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #356.
dcrpoolis an application and thus all of its packages not intended for external consumers should not be publicly visible.To that end, this moves the
guipackage to aninternalpackage meaning that it is no longer a part of the exported main module.