-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui: Show pool payments. #249
Conversation
I think this needs some more work. Since it's an admin page I think we should be showing information that is glanceable: total payments pending most importantly and the total value accrued by pool fees (I need to do some additional work to expose a call for this). The page should also support the usecase where the admin needs to confirm a complaint from a pool user concerning a pending payment. With the user's address or account id the admin should be able to perform a search and see which pending payments are still due the user and which payments have already been processed as well as the blocks the user's mining clients mined on behalf of the pool. |
I will include some additional changes to also display total fees accrued by the pool (and probably also add this to the user payments too). I don't think we need a new call exposing this from the backend because this can be calculated by the front-end using data already in the cache.
All of this information is already displayed to the user when searching for their address on the home page. I don't believe there is any additional information stored in the database which is not being displayed. The only thing missing is the ability to search by account ID, but is that something which would actually be useful? |
I've got some local changes for displaying pending/archived payment totals, but I haven't been table to test locally yet because of the panic described in #251 |
Pending and archived payments to the pool are now displayed on the admin page.
a41ea95
to
ccc79d9
Compare
Rebased and pushed a new commit which displays pending/archived payment totals |
This looks good, I have expanded on what needs further refinement or is missing from the admin section. I think we can proceed with merging this while the others are tackled in separate PRs.
|
Pending and archived payments to the pool are now displayed on the admin page.
First step towards #200