pool: resolve review issues (3 of x).

decred · Sep 16, 2020 · 89827b5 · 89827b5
1 parent e5a3d3d
commit 89827b5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/pool/client.go b/pool/client.go
@@ -453,12 +453,6 @@ func (c *Client) handleSubmitWorkRequest(ctx context.Context, req *Request, allo
 	// by the mining node.
 	work := NewAcceptedWork(hash.String(), header.PrevBlock.String(),
 		header.Height, c.account, c.cfg.FetchMiner())
-	if err != nil {
-		sErr := NewStratumError(Unknown, err)
-		resp := SubmitWorkResponse(*req.ID, false, sErr)
-		c.ch <- resp
-		return err
-	}
 	err = work.Create(c.cfg.DB)
 	if err != nil {
 		// If the submitted accepted work already exists, ignore the

diff --git a/pool/upgrades_test.go b/pool/upgrades_test.go
@@ -185,8 +185,8 @@ func verifyV4Upgrade(t *testing.T, db *bolt.DB) {
 	err := db.View(func(tx *bolt.Tx) error {
 		pbkt := tx.Bucket(poolBkt)
 		if pbkt == nil {
-			return fmt.Errorf("%s: bucket %s not found", string(poolBkt),
-				funcName)
+			return fmt.Errorf("%s: bucket %s not found", funcName,
+				string(poolBkt))
 		}
 
 		v := pbkt.Get([]byte("txfeereserve"))