Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client,webserver: Use the app build version as Version in UI. #3096

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

client,webserver: Use the app build version as Version in UI. #3096

wants to merge 4 commits into from
+34 −54

Conversation

dev-warrior777
Copy link
Contributor

@dev-warrior777 dev-warrior777 commented Nov 24, 2024 •
edited
Loading

Issue: #3091

- Use the value from client/app/version.go
- Place at the foot of Settings dialog
- Re-purpose 'BUILD ID' as the string "Version" for translations and find relevant translations

client,webserver: Use the app build version as Version in UI.
c298ca2 
	- Use the value from client/app/version.go
	- Place at the foot of Settings dialog
	- Re-purpose 'BUILD ID' as "Version for
	  translations and find relevant translations
@dev-warrior777
Copy link
Contributor Author

master: c298ca2
image

  • Left some of the old commitHash code in commented out for viewing
  • Some golang _tests are failing for webserver

@dev-warrior777 dev-warrior777 marked this pull request as ready for review November 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dev-warrior777