Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmui: Fix bugs related to cex connection and balance #3060

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

martonp
Copy link
Contributor

@martonp martonp commented Nov 5, 2024

  • When CEX not connected, show error message when clicking allocate or reconfigure buttons.
  • Add button to remove bot config from mm page.
  • Unwrap cex connection errors.
  • Add ablity to modify testbinance balances.

Closes #3058 and #3034

- When CEX not connected, show error message when clicking allocate or
  reconfigure buttons.
- Add button to remove bot config from mm page.
- Unwrap cex connection errors.
- Add ablity to modify testbinance balances.
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, but if I kill testbinance after starting bw, the front end doesn't seem to know it's disconnected right away. Maybe some notification is missing?

@buck54321 buck54321 merged commit 4d8aeca into decred:master Nov 11, 2024
5 checks passed
buck54321 pushed a commit to buck54321/dcrdex that referenced this pull request Nov 12, 2024
- When CEX not connected, show error message when clicking allocate or
  reconfigure buttons.
- Add button to remove bot config from mm page.
- Unwrap cex connection errors.
- Add ablity to modify testbinance balances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmui: Ugly connection error tooltip
2 participants