bolt: Improve delete inactive orders/matches perf. #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running these functions on a resource contrained machine and a large database was incredibly slow due to overuse of the newestBuckets func. Every key was accessed and sorted every time a batch of orders/matches was processed. Rather than repeatedly performing this work, the full set of keys is now accessed only once. The resulting code runs ~200x faster. There is a slight change in behaviour because database transactions are now committed with a *maximum* of 1000 deletions rather than *exactly* 1000. This is not an issue because the exact size of each transaction doesn't matter, the important point is to limit the maximum size of each transaction to prevent excess memory consumption. This performance gain removes the need to log the progress of each individual batch, so now only a summary is logged after the entire deletion process is completed.
dev-warrior777
approved these changes
Nov 6, 2024
|
Just reviewed history and noticed @JoeGruffins was the original author of this code. Care to give it a once over Joe? |
JoeGruffins
approved these changes
Nov 7, 2024
buck54321
pushed a commit
to buck54321/dcrdex
that referenced
this pull request
Nov 12, 2024
Running these functions on a resource contrained machine and a large database was incredibly slow due to overuse of the newestBuckets func. Every key was accessed and sorted every time a batch of orders/matches was processed. Rather than repeatedly performing this work, the full set of keys is now accessed only once. The resulting code runs ~200x faster. There is a slight change in behaviour because database transactions are now committed with a *maximum* of 1000 deletions rather than *exactly* 1000. This is not an issue because the exact size of each transaction doesn't matter, the important point is to limit the maximum size of each transaction to prevent excess memory consumption. This performance gain removes the need to log the progress of each individual batch, so now only a summary is logged after the entire deletion process is completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running these functions on a resource contrained machine and a large database was incredibly slow due to overuse of the
newestBucketsfunc. Every key was accessed and sorted every time a batch of orders/matches was processed.Rather than repeatedly performing this work, the full set of keys is now accessed only once. The resulting code runs ~200x faster.
There is a slight change in behaviour because database transactions are now committed with a maximum of 1000 deletions rather than exactly 1000. This is not an issue because the exact size of each transaction doesn't matter, the important point is to limit the maximum size of each transaction to prevent excess memory consumption.
This performance gain removes the need to log the progress of each individual batch, so now only a summary is logged after the entire deletion process is completed.