client/webserver: Update Order-details Type to show the correct value. #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dev-warrior777
commented
Oct 27, 2024
dev-warrior777
commented
Currently the order details Type is showing market.quoteUnitInfo.conventional.unit Also cleaned up walletpair BW_ARGS to override dexc.conf options.
|
Hopefully can resolve #3044 |
|
Current conflicts are in walletpair which is just a suggested upgrade to |
ukane-philemon
suggested changes
Oct 27, 2024
|
Should
..or are these terms understood/used by traders? |
|
See e.g. |
Some locales still default to locale en_US but it is the correct order type. There is not yet any translation for order type cancel
|
TODO:
Since UI details get noticed we may want to put the above into the point release as is. I will work on missing translations in another PR. |
|
How about this? buck54321/dcrdex@017099c...buck54321:dcrdex:user-order-type-intl |
That is much more complete .. I will update using your approach of a new OrderUtil util, thanks |
Make a new fn 'orderTypeText' in orderutil.ts that returns the translated text representation for order types: - limit - market - cancel Also added simplified chinese translations for these 3 order types in jsintl.go
buck54321
approved these changes
Oct 30, 2024
buck54321
pushed a commit
that referenced
this pull request
Oct 30, 2024
#3044) * client/webserver: Update Order-details Type to show the correct value. * Also cleaned up walletpair BW_ARGS to override dexc.conf options. --------- Co-authored-by: dev-warrior777 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.