dcr: Remove tx history wait. #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example showing this behavior https://go.dev/play/p/F6KWiFSUfZb |
buck54321
requested changes
Oct 11, 2024
client/asset/dcr/dcr.go
Outdated
| var wg sync.WaitGroup | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| dcr.syncTxHistory(ctx, uint64(newTipHeight)) | ||
| }() | ||
| go dcr.syncTxHistory(ctx, uint64(newTipHeight)) |
There was a problem hiding this comment.
How about using the ExchangeWallet.wg here instead so at least we don't have an unmonitored goroutine?
There was a problem hiding this comment.
JoeGruffins
force-pushed
the
fixstartupdcrhang
branch
from
cf6665c
to
ec312e6
Compare
SyncStatus has a chance to hold the tipMtx so run it in a goroutine and do not wait.
JoeGruffins
force-pushed
the
fixstartupdcrhang
branch
from
ec312e6
to
9cc5f72
Compare
buck54321
approved these changes
Oct 11, 2024
buck54321
pushed a commit
to buck54321/dcrdex
that referenced
this pull request
Oct 17, 2024
SyncStatus has a chance to hold the tipMtx so run it in a goroutine and do not wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2971
handleTipChangemust wait until the go functions are finished, so the tipMtx is held for writes for both of them. syncTxHistory calls SyncStatus which also conditionally holds the tipMtx for reads, randomly causing deadlock. I think running syncTxHistory as a goroutine and not waiting is the simplest answer.