Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Show what version is being run #3091

Open
exitus1 opened this issue Nov 21, 2024 · 10 comments
Open

UI: Show what version is being run #3091

exitus1 opened this issue Nov 21, 2024 · 10 comments

Comments

@exitus1
Copy link

exitus1 commented Nov 21, 2024

People upgrading are asking how to know if they upgraded. Would be nice to have the version # somewhere in settings.

https://x.com/julianchuk/status/1859401033149014027

@norwnd
Copy link
Contributor

norwnd commented Nov 21, 2024

For additional context,

we have Build ID (in settings) already, but it would also be nice to additionally have a "release version" (in case a commit corresponds to official release) - since it removes 1 additional step of linking Build ID to release manually.

@dev-warrior777
Copy link
Contributor

dev-warrior777 commented Nov 22, 2024

People upgrading are asking how to know if they upgraded. Would be nice to have the version # somewhere in settings.

image

About could show:

  1. BisonW Version v1.x.x (Always)
  2. Git commit (if available - depends on the build process) OR module version
  3. Maybe copyright?

@exitus1
Copy link
Author

exitus1 commented Nov 22, 2024

Looks good. Maybe call it "Version" instead of About?

@dev-warrior777
Copy link
Contributor

Can, but then I would just put the version at the bottom of the settings dialog. The build ID is problematic as it may not be available or may be incorrect as can be seen by the long conversation in the dex-dev channel with jrick/davec.

Ok, first I will look at making sure we have at least the version at the bottom of the Settings dialog and no separate About dialog .. which is very overkill just for Version. Then if there is a valid git commit (based on what the go code says) .. put that underneath.

Then users can just hit the settings link to get the version info.

@norwnd
Copy link
Contributor

norwnd commented Nov 23, 2024

Can, but then I would just put the version at the bottom of the settings dialog.

Build ID is a sort of version, just a different one. I think what @exitus1 suggests is a cleaner way to go about it, but given both version and trimmed-commit are short enough it might be possible to just combine them together into something like v1.0.2 (1fd2fce) to put at the bottom of the settings dropdown menu.

@dev-warrior777 while you are modifying this dropdown menu do you think you could also address these ?

  • "Market Making" tab in there seems to be redundant since "MM bot" button (see screenshot below) seems to already lead user to market-making page
  • "order history" tab should probably be more visible, I'd suggest to move it out of this dropdown menu and put it in between "MM bot" and "Notifications" section (on screenshot below) ?
image

@dev-warrior777
Copy link
Contributor

dev-warrior777 commented Nov 23, 2024

@dev-warrior777 while you are modifying this dropdown menu do you think you could also address these ?

I will not be changing the drop-down .. rather arranging for app.Version to be visible in the Settings dialog underneath the Redeem game code div/section. With or without the problematic Build ID. Build Id is often useless when grabbed from golang embedded module info.

I can look at the dropdown issues but not on the PR coming out of this.

@martonp might look at Market Making link versus Market Making robot icon click. You may be right and we do not need it now.

Did you read @jrick 's helpful comments in dex-dev channel?

@norwnd
Copy link
Contributor

norwnd commented Nov 23, 2024

Did you read @jrick 's helpful comments in dex-dev channel?

Most of it, why ? If you mean we can't always have the version available - I guess just set it to unknown as fallback, but that's probably a rare case to hit in practice (most users will use pre-built binary, and obviously the one releasing those binaries should build it such that both version and commit is available).

@dev-warrior777
Copy link
Contributor

dev-warrior777 commented Nov 24, 2024

most users will use pre-built binary, and obviously the one releasing those binaries should build it such that both version and commit is available

We can show the actual build always I think. PR later today.

@dev-warrior777
Copy link
Contributor

"Market Making" tab in there seems to be redundant since "MM bot" button (see screenshot below) seems to already lead user to market-making page

Yes .. both go to host/mm .. maybe one can be removed .. let's see what @martonp wants to do

@dev-warrior777
Copy link
Contributor

People upgrading are asking how to know if they upgraded. Would be nice to have the version # somewhere in settings.

Workaround for now if the person is comfortable with console/command prompt/dos box then find the executable such as bisonw.exe, bisonw .. open a command prompt and:

  • C: bisonw.exe --version
  • $ ./bisonw --version

Should show bisonw version 1.0.2+release.local (Go version go1.23.0 linux/amd64) with latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants