-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Show what version is being run #3091
Comments
For additional context, we have Build ID (in settings) already, but it would also be nice to additionally have a "release version" (in case a commit corresponds to official release) - since it removes 1 additional step of linking Build ID to release manually. |
Looks good. Maybe call it "Version" instead of About? |
Can, but then I would just put the version at the bottom of the settings dialog. The build ID is problematic as it may not be available or may be incorrect as can be seen by the long conversation in the dex-dev channel with jrick/davec. Ok, first I will look at making sure we have at least the version at the bottom of the Settings dialog and no separate About dialog .. which is very overkill just for Version. Then if there is a valid git commit (based on what the go code says) .. put that underneath. Then users can just hit the settings link to get the version info. |
Build ID is a sort of version, just a different one. I think what @exitus1 suggests is a cleaner way to go about it, but given both version and trimmed-commit are short enough it might be possible to just combine them together into something like @dev-warrior777 while you are modifying this dropdown menu do you think you could also address these ?
|
I will not be changing the drop-down .. rather arranging for app.Version to be visible in the Settings dialog underneath the Redeem game code div/section. With or without the problematic Build ID. Build Id is often useless when grabbed from golang embedded module info. I can look at the dropdown issues but not on the PR coming out of this. @martonp might look at Did you read @jrick 's helpful comments in dex-dev channel? |
Most of it, why ? If you mean we can't always have the version available - I guess just set it to |
We can show the actual build always I think. PR later today. |
Yes .. both go to |
Workaround for now if the person is comfortable with console/command prompt/dos box then find the executable such as
Should show |
People upgrading are asking how to know if they upgraded. Would be nice to have the version # somewhere in settings.
https://x.com/julianchuk/status/1859401033149014027
The text was updated successfully, but these errors were encountered: