Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vmiplease): fix deletion after time of not claimed #543

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix(vmiplease): fix deletion after time of not claimed #543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f8127
fix
Nov 28, 2024
ed1a06b
Merge branch 'main' into fix/vmiplease/fix-deletion
eofff Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions images/virtualization-artifact/pkg/controller/vmiplease/internal/lifecycle_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ func (h *LifecycleHandler) Handle(ctx context.Context, state state.VMIPLeaseStat
Reason(conditions.ReasonUnknown).
Status(metav1.ConditionUnknown)

defer func() {
conditions.SetCondition(cb, &leaseStatus.Conditions)
}()

vmip, err := state.VirtualMachineIPAddress(ctx)
if err != nil {
return reconcile.Result{}, err
Expand All @@ -64,13 +60,15 @@ func (h *LifecycleHandler) Handle(ctx context.Context, state state.VMIPLeaseStat
leaseStatus.Phase = virtv2.VirtualMachineIPAddressLeasePhaseBound
cb.Status(metav1.ConditionTrue).
Reason(vmiplcondition.Bound)
conditions.SetCondition(cb, &leaseStatus.Conditions)
}
} else {
if leaseStatus.Phase != virtv2.VirtualMachineIPAddressLeasePhaseReleased {
leaseStatus.Phase = virtv2.VirtualMachineIPAddressLeasePhaseReleased
cb.Status(metav1.ConditionFalse).
Reason(vmiplcondition.Released).
Message("VirtualMachineIPAddress lease is not used by any VirtualMachineIPAddress")
conditions.SetCondition(cb, &leaseStatus.Conditions)
}
}

Expand Down
Loading