-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Selenium 4.0 deprecation message #38
base: master
Are you sure you want to change the base?
Conversation
@rubendinho is there anything blocking this PR so that this issue can be resolved? |
@blehoux17 I don't believe so - I don't have write permissions to this repo to merge it though. |
@rubendinho What will merging this to do old versions of Chromedriver? Does this need to be a breaking version change? |
Thanks for responding @dbalatero! I think this can easily be made backwards compatible: browser = Capybara.current_session.driver.browser
logs = browser.respond_to?(:logs) ? browser.logs : browser.manager.logs
logs.get(type) What do you think @rubendinho? |
@synth I think this should work nicely. Unfortunately, we're no longer using this library so I can't verify. |
Hey @dbalatero! Just bubbling this back up and tagging you as one of the contributors of this repo. Is there anything blocking this PR from being merged? I see that you 👍'd @synth's suggestion - I am wondering if you able to merge this in? |
@dbalatero Any update? |
Fixes #34