Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Selenium 4.0 deprecation message #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubendinho
Copy link

Fixes #34

@blehoux17
Copy link

@rubendinho is there anything blocking this PR so that this issue can be resolved?

@rubendinho
Copy link
Author

@rubendinho is there anything blocking this PR so that this issue can be resolved?

@blehoux17 I don't believe so - I don't have write permissions to this repo to merge it though.

@dbalatero
Copy link
Owner

dbalatero commented Aug 28, 2022

@rubendinho What will merging this to do old versions of Chromedriver? Does this need to be a breaking version change?

@synth
Copy link

synth commented Aug 28, 2022

Thanks for responding @dbalatero! I think this can easily be made backwards compatible:

browser = Capybara.current_session.driver.browser
logs = browser.respond_to?(:logs) ? browser.logs : browser.manager.logs                 
logs.get(type)

What do you think @rubendinho?

@rubendinho
Copy link
Author

@synth I think this should work nicely. Unfortunately, we're no longer using this library so I can't verify.

@ashik-v
Copy link

ashik-v commented Dec 19, 2022

Hey @dbalatero! Just bubbling this back up and tagging you as one of the contributors of this repo. Is there anything blocking this PR from being merged? I see that you 👍'd @synth's suggestion - I am wondering if you able to merge this in?

@v-kumar
Copy link

v-kumar commented Feb 23, 2023

@dbalatero Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager#logs deprecation warning after upgrading to Selenium 4.0
6 participants