Move MAFFT and FastTree config into config.json #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I thought it would be better to have the configuration of MAFFT and FastTree into the config.json file for the following reasons :
Maybe it was in program_caller.py because they are default methods for MSA so you want them to be present so it wouldn't break ? But it is not the case for DIAMOND and MCL which are also default methods. So there may be another reason ?
Also, it might be good to make the FASTME command call more visible. Sorry, I'm obsessed with what parameters are used at which time.
Cheers,
dilema
P.S. : Thanks for the awesome tool and especially the last update with HOG, I was trying to do it manually. You saved me so much time !