HTTP Status Errors: enrich-and-reraise #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new astrapy exception in the class hierarchy,
DataAPIHttpException
, sibling toDataApiResponseException
.The new one represents 4xx/5xx responses from the API. Since in some cases these responses still contain useful info in the standard
{"errors": [...]}
format, which would be omitted in string representation of the httpx exception, now astrapy does the following:Note that the new error class (see
pictures/astrapy_exceptions.png
) inherits from bothDataAPIException
and the httpx class: this, while not presenting relevant "diamond-type" multiple-inheritance problems, allows current flows based on catching the httpx exceptions to continue working.