Mismatched Keys: Update read_dlt_delta() with key "source_database" instead of "database" #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onboard_dataflowspec.py sets key "source_database" when creating bronze dataflow spec dataframe inside source details. However read_dlt_delta tries to read "database" instead.
|
|
|
Please fix Unit Tests |
| @@ -62,14 +62,14 @@ def read_dlt_delta(spark, bronze_dataflow_spec) -> DataFrame: | |||
| if reader_config_options and len(reader_config_options) > 0: | |||
| return ( | |||
| spark.readStream.options(**reader_config_options).table( | |||
| f"""{bronze_dataflow_spec.sourceDetails["database"]} | |||
| f"""{bronze_dataflow_spec.sourceDetails["source_database"]} | |||
There was a problem hiding this comment.
Can we introduce a variable, say source_table for the value and use it in these two places (so it's clear(er) that they're the same)? 🙏
|
Can this be resolved please? |
ravi-databricks
approved these changes
Apr 15, 2024
fixed unit tests for changing keys in delta pipeline reader
|
merged this for v0.0.7 release. |
|
@prabhat-ratnala this is fixed in release v.0.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When the bronze_dataflow_spec dataframe is created in
onboard_dataflowspec.py, the database is included with keysource_databasein thesourceDetailsfield. However, inpipeline_readers.py>read_dlt_delta(), it is accessed with keydatabaseinstead.Fix:
Change the key to
source_databaseinpipeline_readers.py>read_dlt_delta().