Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN-675] add hadoop compatible filesystem changes to sftp-put plugin #35

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jster1357
Copy link

@jster1357 jster1357 commented Aug 3, 2023

JIRA: https://cdap.atlassian.net/browse/PLUGIN-675

Add hadoop compatible changes to sftp-put plugin
cleaned up some formatting in the docs

cleaned up some formatting in the docs
@jster1357 jster1357 changed the title add hadoop compatible changes to sftp-put plugin add hadoop compatible filesystem changes to sftp-put plugin Aug 3, 2023
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good,

one suggestion: we can also add a config in the plugin to add file system props as present in SFTP Copy plugin.
ref: https://github.com/data-integrations/sftp-actions/blob/becf6c3044df199598b5b355e47a7de836409b00/src/main/java/io/cdap/plugin/SFTPCopyAction.java

@itsankit-google itsankit-google changed the title add hadoop compatible filesystem changes to sftp-put plugin [PLUGIN-675] add hadoop compatible filesystem changes to sftp-put plugin Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants