Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pf4): Use PF5 name for WizardBody no padding #1476

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

randomnetcat
Copy link
Contributor

@randomnetcat randomnetcat commented Jul 17, 2024

Description

In the new PF5 wizard, the prop to disable body padding is called hasNoPadding rather than hasNoBodyPadding.

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 4:29pm

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (dac8b99) to head (dd4bb78).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files         210      210           
  Lines        3975     3975           
  Branches     1629     1629           
=======================================
  Hits         3756     3756           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randomnetcat randomnetcat changed the title Use PF5 name for WizardBody no padding fix: Use PF5 name for WizardBody no padding Jul 17, 2024
@randomnetcat randomnetcat changed the title fix: Use PF5 name for WizardBody no padding fix(pf4): Use PF5 name for WizardBody no padding Jul 17, 2024
@rvsia rvsia added bug Something isn't working PF4 PF4 pull request labels Jul 18, 2024
@rvsia rvsia merged commit 4a49abd into data-driven-forms:master Jul 18, 2024
6 checks passed
@rvsia rvsia added the released label Jul 18, 2024
@randomnetcat randomnetcat deleted the wizard-padding branch July 18, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PF4 PF4 pull request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants