Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Row-Wise Mode Functionality (axis=1) and Improve Metadata Handling in _collection.py #1137

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Sep 19, 2024

  1. Update _collection.py

    - Added functionality for row-wise mode calculation (axis=1) to support the Dask DataFrame API.
    - The new implementation dynamically handles row-wise mode and ensures consistent metadata handling across partitions.
    - Added validation for the axis parameter, with appropriate error handling for unsupported values.
    - Ensured compatibility with existing column-wise (axis=0) mode functionality, preserving the original behavior for that case.
    
    Resolves dask-expr issue dask#1136.
    thyripian committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4dd4ff0 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Reformat _collection.py

    Formatted _collection.py with Black
    thyripian committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e976f38 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Refactor row-wise mode functionality in mode method

    Simplified the logic for row-wise mode computation (axis=1) to dynamically handle multiple modes per row. Refactored metadata handling to ensure the number of columns is consistent across partitions, avoiding mismatches in column count. This addresses issues with inconsistent column numbers between computed data and metadata in Dask, and addresses dev team feedback.
    thyripian committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    bc340ee View commit details
    Browse the repository at this point in the history
  2. drop venv

    My bad. Git desktop added my venv to the last push but I didn't see it.
    thyripian committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    9f918ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddaef07 View commit details
    Browse the repository at this point in the history
  4. Refactor to rely solely on meta_nonempty for row-wise mode

    Modified row-wise mode implementation to rely entirely on self._meta_nonempty for metadata generation, as per developer feedback. Ensured complete removal of explicit typecasting and ensured consistent column handling between computed data and metadata.
    thyripian committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    f8b6463 View commit details
    Browse the repository at this point in the history
  5. Run pre-commit linting

    Made linting changes, specifically for black.
    thyripian committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    894bd9c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    1dbdd2d View commit details
    Browse the repository at this point in the history