-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Row-Wise Mode Functionality (axis=1) and Improve Metadata Handling in _collection.py #1137
Open
thyripian
wants to merge
8
commits into
dask:main
Choose a base branch
from
thyripian:feature/rowwise-mode-support-gh1136
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Row-Wise Mode Functionality (axis=1) and Improve Metadata Handling in _collection.py #1137
thyripian
wants to merge
8
commits into
dask:main
from
thyripian:feature/rowwise-mode-support-gh1136
Commits on Sep 19, 2024
-
- Added functionality for row-wise mode calculation (axis=1) to support the Dask DataFrame API. - The new implementation dynamically handles row-wise mode and ensures consistent metadata handling across partitions. - Added validation for the axis parameter, with appropriate error handling for unsupported values. - Ensured compatibility with existing column-wise (axis=0) mode functionality, preserving the original behavior for that case. Resolves dask-expr issue dask#1136.
Configuration menu - View commit details
-
Copy full SHA for 4dd4ff0 - Browse repository at this point
Copy the full SHA 4dd4ff0View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e976f38 - Browse repository at this point
Copy the full SHA e976f38View commit details
Commits on Oct 6, 2024
-
Refactor row-wise mode functionality in mode method
Simplified the logic for row-wise mode computation (axis=1) to dynamically handle multiple modes per row. Refactored metadata handling to ensure the number of columns is consistent across partitions, avoiding mismatches in column count. This addresses issues with inconsistent column numbers between computed data and metadata in Dask, and addresses dev team feedback.
Configuration menu - View commit details
-
Copy full SHA for bc340ee - Browse repository at this point
Copy the full SHA bc340eeView commit details -
My bad. Git desktop added my venv to the last push but I didn't see it.
Configuration menu - View commit details
-
Copy full SHA for 9f918ac - Browse repository at this point
Copy the full SHA 9f918acView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddaef07 - Browse repository at this point
Copy the full SHA ddaef07View commit details -
Refactor to rely solely on meta_nonempty for row-wise mode
Modified row-wise mode implementation to rely entirely on self._meta_nonempty for metadata generation, as per developer feedback. Ensured complete removal of explicit typecasting and ensured consistent column handling between computed data and metadata.
Configuration menu - View commit details
-
Copy full SHA for f8b6463 - Browse repository at this point
Copy the full SHA f8b6463View commit details -
Made linting changes, specifically for black.
Configuration menu - View commit details
-
Copy full SHA for 894bd9c - Browse repository at this point
Copy the full SHA 894bd9cView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1dbdd2d - Browse repository at this point
Copy the full SHA 1dbdd2dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.