Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456
It's clear from #456 that the complexity around
axis=0
concatenation makes it hard to reason about!The bug is caused by the loss of
report
objects associated with secondary arrays in the concatenate call; right now we take the first array (because all arrays are coerced to the same form) as the "meta".To fix this, we need to build a "parent" meta such that
parent.touch_data("key-1")
invokeschild1.touch_data("key-1-child")
,child2.touch_data("key-2-child")
, and so on.I'll try and clean this up, probably with an Awkward fix, in the near future.