Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement pointToLineDistance #189

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

mhammerc
Copy link
Contributor

@mhammerc mhammerc commented Aug 9, 2024

Hello,

I have implemented the pointToLineDistance function. The implementation and tests are adapted from Turf.js, and I have noted this in the source code. Please let me know if any additional steps are needed regarding this.

All tests have passed, and they match the ones used in Turf.js.

Please let me know if there are any issues or if anything needs to be adjusted.

Thank you for your work on the library!

@mhammerc mhammerc force-pushed the feat/point_to_line_distance branch 6 times, most recently from 47a6e47 to 450e549 Compare August 9, 2024 16:38
@mhammerc mhammerc force-pushed the feat/point_to_line_distance branch from 450e549 to cedf64d Compare August 9, 2024 16:42
Copy link
Member

@lukas-h lukas-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@lukas-h
Copy link
Member

lukas-h commented Aug 10, 2024

Hey @mhammerc, I just reviewed – didn't find anything and will go ahead and merge.

@lukas-h lukas-h merged commit da48c29 into dartclub:main Aug 10, 2024
1 check passed
@lukas-h
Copy link
Member

lukas-h commented Aug 10, 2024

Thanks a lot for your contribution :) @mhammerc

@mhammerc
Copy link
Contributor Author

Thanks a lot for your contribution :) @mhammerc

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants