Collect dt_control_log() and dt_toast_log() messages #16967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
feature: enhancement
|
@jenshannoschwalm : The discussion was there #16611 |
|
Note that in this discussion I have even proposed a new button to be able to browse the log in a dialog. |
Right, #16611 was it. Although i personally think this here is sufficient. |
jenshannoschwalm
force-pushed
the
collected_messages
branch
2 times, most recently
from
9ddc846
to
982bb91
Compare
jenshannoschwalm
force-pushed
the
collected_messages
branch
2 times, most recently
from
b5a21e1
to
361d212
Compare
jenshannoschwalm
force-pushed
the
collected_messages
branch
from
361d212
to
21577e9
Compare
jenshannoschwalm
force-pushed
the
collected_messages
branch
2 times, most recently
from
d730bac
to
bc83e0a
Compare
Visibility of messges shown via dt_control_log(), dt_toast_log() and dt_toast_markup_log() is currently pretty bad as only the last shown message is shown if new ones are "pushed". This commit redesigns both buffers to be used as circular buffers, a new call to any function above will not display the last text but all available and not-yet ackknowledged (or disappered) messages for improved user readability.
jenshannoschwalm
force-pushed
the
collected_messages
branch
from
bc83e0a
to
f202272
Compare
TurboGit
approved these changes
Aug 5, 2024
|
|
|
behaviour of dterrahe reproducible on macOS: |
|
Yes, this is how it's been designed. Take it as a simple-solution proposal instead of collecting to a buffer/window that can be selected and opened. If this information collection is enough - instead of something more complex - i could add a preference option for "how many lines" to make this less "offensive". Otherwise - if this feature is not liked or not good enough by others, we can just revert. |
jenshannoschwalm
added a commit
to jenshannoschwalm/darktable
that referenced
this pull request
Aug 6, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines choosable via preferences between 0 (down't show any) and a max of 8. Fixes comments in darktable-org#16967
jenshannoschwalm
added a commit
to jenshannoschwalm/darktable
that referenced
this pull request
Aug 6, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines choosable via preferences between 0 (down't show any) and a max of 8. Fixes comments in darktable-org#16967
jenshannoschwalm
added a commit
to jenshannoschwalm/darktable
that referenced
this pull request
Aug 6, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines choosable via preferences between 0 (down't show any) and a max of 15. Fixes comments about index errors and UI in darktable-org#16967
jenshannoschwalm
added a commit
to jenshannoschwalm/darktable
that referenced
this pull request
Aug 6, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines a) 1 for toast b) 7 for log messages so there is a still a good chance to see every log message Fixes comments about index errors and UI in darktable-org#16967
TurboGit
pushed a commit
that referenced
this pull request
Aug 6, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines a) 1 for toast b) 7 for log messages so there is a still a good chance to see every log message Fixes comments about index errors and UI in #16967
jenshannoschwalm
added a commit
to jenshannoschwalm/darktable
that referenced
this pull request
Aug 6, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines a) 1 for toast b) 7 for log messages so there is a still a good chance to see every log message Fixes comments about index errors and UI in darktable-org#16967
marc-fouquet
pushed a commit
to marc-fouquet/darktable
that referenced
this pull request
Sep 13, 2024
The number of lines shown for toast and log messages could be felt to be too offensive, this PR makes the number of lines a) 1 for toast b) 7 for log messages so there is a still a good chance to see every log message Fixes comments about index errors and UI in darktable-org#16967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visibility of messages shown via
dt_control_log(),dt_toast_log()anddt_toast_markup_log()is currently pretty bad as only the last shown message is shown if new ones are "pushed".This commit redesigns both buffers to be used as circular buffers, a new call to any function above will not display the last text but all available and not-yet ackknowledged (or disappeared) messages for improved user readability.
I think there was some discussion - can't find it right now - @TurboGit and @victoryforce iirc about some sort of larger log to be shown on request or something like that. This pr would be a very simply&safe redesign showing the last bunch of messages. No new strings, nothing "unusual" ...