Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAQ: Mask PASSKEY variable coming from HTTP, emitted by Ecowitt #123

Closed
wants to merge 1 commit into from

Conversation

amotl
Copy link
Member

@amotl amotl commented Mar 1, 2023

Hi there,

in order to support acquiring data from an Ecowitt device 1, this patch will mask the PASSKEY variable from the ingress data. It should not be part of the measurement readings.

With kind regards,
Andreas.

Footnotes

  1. https://community.hiveeyes.org/t/ecowitt-wunderground-api-fur-weather-hiveeyes-org-nutzbar/4735

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (de224af) 52.67% compared to head (2dd0beb) 52.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   52.67%   52.69%   +0.02%     
==========================================
  Files          99       99              
  Lines        5221     5224       +3     
==========================================
+ Hits         2750     2753       +3     
  Misses       2471     2471              
Flag Coverage Δ
unittests 52.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kotori/io/protocol/http.py 82.90% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amotl
Copy link
Member Author

amotl commented Mar 2, 2023

Closing this in favor of GH-125.

@amotl amotl closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant