Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show get sub banner in Creators Page if not logged in #134

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

teodorus-nathaniel
Copy link
Contributor

@teodorus-nathaniel teodorus-nathaniel commented Jan 9, 2024

Currently, users that haven't logged in won't see get sub banner

@teodorus-nathaniel
Copy link
Contributor Author

I used getAddressesFromStorage because useMyAddress has a delay on the first load, where it has the first value of undefined.
To remove the flashing of get sub banner if I am logged in, I used the one from storage where it won't have any delay

I change useMemo to useEffect and useState to not have hydration issue

@teodorus-nathaniel teodorus-nathaniel self-assigned this Jan 9, 2024
@teodorus-nathaniel teodorus-nathaniel added the enhancement New feature or request label Jan 9, 2024
@teodorus-nathaniel teodorus-nathaniel merged commit c9db164 into main Jan 9, 2024
1 check passed
@teodorus-nathaniel teodorus-nathaniel deleted the improvement/get-sub branch January 9, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants