patch rad_accel_ptmass to be used with FSI #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fix is pretty horrible, can we understand why it doesn't work with the acceleration computed inside the get_force routine? I would strongly prefer it to stay there if possible... |
|
It's already the case. I also agree that this part should stay in the get_force routine. The point was on where it was in this routine. Sorry for the misleading. I badly explained myself in #538. |
|
sorry I think I misunderstood the change here. I added a fix to the mcfost build failure... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix, fixes #538
Description:
Patch the rad_accel_ptmass routine to be correctly used with the new FSI scheme.
Testing:
Did you run the bots? no
Did you update relevant documentation in the docs directory? no