Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind tunnel setup and injection module #470

Merged
merged 14 commits into from
Oct 15, 2023
Merged

Wind tunnel setup and injection module #470

merged 14 commits into from
Oct 15, 2023

Conversation

themikelau
Copy link
Collaborator

@themikelau themikelau commented Sep 28, 2023

New setup and injection module "windtunnel" for gas polytrope in a windtunnel. Input parameters include wind speed, wind pressure, wind density, sphere radius, and sphere mass.

  • Note that I have changed the logic of set_star_density to "know" mass_is_set = .true. when massoftype(igas) > tiny(0.) (indifferent to the value of npart). This is needed for the wind tunnel, where the particle mass must be known and set before setting up the star, so that the wind can be initialised. An implication of this is that massoftype should not be initialised to zero in setup_binary, which seems to be unnecessary anyway.

Future work:

  • Generalise the gas polytrope to any "star" that can already be set up using the setstar module
  • Allow for arbitrary EoS, which is currently hard-wired to be an ideal gas EoS.
  • Perhaps combine this with the BHL modules.

@themikelau themikelau marked this pull request as ready for review October 10, 2023 14:08
@danieljprice danieljprice merged commit b324cf1 into master Oct 15, 2023
177 checks passed
@danieljprice danieljprice deleted the windtunnel branch October 15, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants