Persist decks #461
Open
Persist decks #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for having a mapping from account pubkey to `Columns` struct so accounts can have their own Columns. This doesn't fully satisfy the intended decks implementation, but it is getting closer Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
This merges the full deck draft with some fixes into full_decks_support.
This brings in a few fixes from master as well.
kernelkind (12):
basic decks impl
full deck impl
WIP: configure deck view
add decks edit
integrate NewDeck in app
WIP: side panel show decks
deck switching
WIP: EditDeckView
integrate EditDeckView
integrate deck deletion
TMP: secondary click to edit deck
perform switching account/deck switching current frame
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
kernelkind
force-pushed
the
persist_decks
branch
from
7d05860
to
0e8233d
Compare
|
can you rebase and squash this into relevant commits ? it's becoming too difficult to review |
Signed-off-by: kernelkind <kernelkind@gmail.com>
yes |
|
might need a rebase instead of merge. also looks like you merged the wrong master |
|
this rebase might be tricky... may need to squash a bunch of stuff first on the original base branch since there are so many edit commits |
|
yeah this is pretty brutal. I will try to fix |
removed in ee5dd54 Signed-off-by: kernelkind <kernelkind@gmail.com>
Signed-off-by: kernelkind <kernelkind@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #452