Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type mismatch error for arm #8

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix type mismatch error for arm #8

merged 3 commits into from
Aug 24, 2023

Conversation

BIBIN-EUGINE
Copy link
Contributor

Description

Resolved the portable issues of mseed crate for arm target

Testing

Tested this changes with cross compliation for arm target and it complied successfully.

@BIBIN-EUGINE BIBIN-EUGINE mentioned this pull request Aug 23, 2023
Closed
@BIBIN-EUGINE
Copy link
Contributor Author

Hi @damb , This PR is ready for review. Thanks

@damb
Copy link
Owner

damb commented Aug 23, 2023

Great. Could you please fix the formatting, firstly. cargo-fmt is your friend. Thanks.

@damb damb added enhancement New feature or request maintenance Maintenance related labels Aug 23, 2023
fix type mismatch error for arm
aa5591c 
fix the formatting erros
damb
damb requested changes Aug 24, 2023
View reviewed changes
Copy link
Owner

@damb damb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

Could you fix the requested changes, please? Also, could you have a look at the examples in the examples directory since they might require additional changes?

In addition, do you have experience with ARM based test runners for GitHub actions? It would be nice to have tests being executed on ARM, too.

src/io.rs Outdated Show resolved Hide resolved
src/pack.rs Outdated Show resolved Hide resolved
src/pack.rs Outdated Show resolved Hide resolved
src/record.rs Outdated Show resolved Hide resolved
src/pack.rs Outdated Show resolved Hide resolved
src/trace.rs Outdated Show resolved Hide resolved
src/trace.rs Outdated Show resolved Hide resolved
src/trace.rs Outdated Show resolved Hide resolved
src/record.rs Outdated Show resolved Hide resolved
src/pack.rs Outdated Show resolved Hide resolved
@damb damb merged commit d18b34d into damb:main Aug 24, 2023
2 checks passed
@damb
Copy link
Owner

damb commented Aug 24, 2023

Thank you again. It would be nice if you still could check whether the examples need a fix. In case of errors a PR is very welcome.

@damb damb mentioned this pull request Aug 24, 2023
Closed
@damb damb linked an issue Aug 24, 2023 that may be closed by this pull request
Port mseed crate to arm #6
Closed
@damb damb mentioned this pull request Aug 24, 2023
Open
@BIBIN-EUGINE
Copy link
Contributor Author

Thank you again. It would be nice if you still could check whether the examples need a fix. In case of errors a PR is very welcome.

I have verified all the examples works as expected.

@BIBIN-EUGINE
Copy link
Contributor Author

BIBIN-EUGINE commented Aug 25, 2023 •
edited
Loading

Thanks a lot.

Could you fix the requested changes, please? Also, could you have a look at the examples in the examples directory since they might require additional changes?

In addition, do you have experience with ARM based test runners for GitHub actions? It would be nice to have tests being executed on ARM, too.

I haven't explored GitHub actions yet, If you already have experience with this then I am happy for you to pursue.
In addition, I am also seeing some other issues with this crate...will post more about it soon as a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damb damb damb approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request maintenance Maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port mseed crate to arm
2 participants
@BIBIN-EUGINE @damb