[WIP] Add support for pendulum 3 #19456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendulum 2.x does not pip install in python 3.12.
`dst_rule == TRANSITION_ERROR` becomes `raise_on_unknown_times=True` `dst_rule == PRE_TRANSITION` becomes `fold=0` `dst_rule == POST_TRANSITION` becomes `fold=1`
In pendulum 3.0 DateTime.day_of_week returns 0 for Monday, while previously returned 0 for Sunday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I was interested in running dagster on python 3.12. There are two blockers that I am aware of:
This PR is a WIP attempt to solve the first, by allowing pendulum 3.0, which is compatible with python 3.12. Unfortunately, the rabbit hole was much deeper than I thought initially due to the many breaking changes in pendulum 3.0. At this point I don't have more time to spend on this for a while.
Since, I think @gibsondan was also looking into this, I am opening this WIP PR in case it may be of help (otherwise feel free to close it).
In its current state, this PR still has a bunch of unit test failures, mostly related to the scheduler, and a weird segfault on python 3.8.
How I Tested These Changes
Run unit tests locally under python 3.8, 3.10 and 3.12