Remove all remaining references of Guava's Files class. #7278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas R. Mansour <lukas.mansour@desy.de>
kofemann
reviewed
Oct 15, 2024
| if (file.isDirectory()) { | ||
| File[] files = file.listFiles(); | ||
| if (files != null) { | ||
| return Ordering.natural().sortedCopy(asList(files)); |
There was a problem hiding this comment.
I think this can be de-guavaed as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Closes #3808
Modification:
Removes the last instances of com.google.common.io.Files and replaces most of them with the JDK alternative. (Also required updating one or two guava classes, like the
TreeTraverser)Result:
The remaining references of Guava's
Filesclass are removed and some small tweaks to reduce the usage of Guava were done.Signed-off-by: Lukas Mansour lukas.mansour@desy.de