fixes and features - mfa and credentials file support, etc #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ugly rework of `[[ ... =~ ...]]` tests that were failng unexpectedly (bash version issue? I gave up trying to diagnose) using a hopefully more portable simple grep - add support for profiles that are in the credentials file (required for MFA roles) - remove SESSION_PROFILE code, we need to use the extracted profile for MFA profiles to work - make session names less generic, easier to id what created the session - add AWS_EXPIRATION export to allow knowledge of when the token will expire
|
@keen99 thank you very much for the effort and contribution. Before merging I will have to thoroughly test this and ensure the code changes will not introduce any issues on us. So please expect some time until merge.
I've also initially thought about adding this. Be aware if you assume into a login role and then assume further into a permission role, the current AWS limit is 1 hour (unlike only one level of assuming, where you can have 12 hours). Bare with me, I will report any issues or workings on this one and will also address the shellcheck issues. |
|
I have an updated shellcheck installation method for your travis.yml. will submit when i get in front of computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was work done for myself - to support the needs of my environment. figured I'd share it back in case it's helpful.
[[ ... =~ ...]]tests that were failing unexpectedly (bash version issue? I gave up trying to diagnose) using a hopefully more portable simple grep