Fixed issues with generic robot window #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaniapedrazzi
added
the
documentation
|
Can we fix the behavior instead of the documentation? |
Yes, please go ahead with the fix of the behavior. |
|
I can confirm 01d39d1 solves the issue on Ubuntu 20.04 as well |
omichel
changed the title
omichel
added
bug
lukicdarkoo
approved these changes
Jul 14, 2021
|
I just tested on macOS and it works as well. |
omichel
approved these changes
Jul 14, 2021
|
I also tested on Windows and it worked. |
|
It doesn't work with snap on Ubuntu 18.04: EDIT: Actually, it seems that the snap package got generated from the old R2021b Webots tag (we have to tag the webots repo first and then the webots-snap repo). Generating the new snap... EDIT2: It doesn't work. It doesn't with Debian package either. It seems that Webots saves absolute paths when linking. This means it works in our development environments, but as soon as we run a package compiled on CI it doesn't. |
BenjaminDeleze
pushed a commit
that referenced
this pull request
Jul 19, 2021
* Update discord docs. (#3152) Co-authored-by: DavidMansolino <DavidMansolino@github.com> * fix nightly build on windows develop (#3153) * fix nightly build on windows develop * adapt test-source * Publish libcontroller from master branch (#3180) * Publish libcontroller from master branch * Fix * Fix diff * Fix * Update sync_controller_lib.sh * uncomment * Update discord docs. (#3187) Co-authored-by: DavidMansolino <DavidMansolino@github.com> * Avoid Windows deleting webots-libcontroller header files (#3197) * Update sync_controller_lib.sh * Update scripts/packaging/sync_controller_lib.sh Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Fix Windows libcontroller determinism (#3204) * Fix Windows libcontroller detertinism * Guards * Update test_suite_windows.yml * Update test_suite_windows_develop.yml * EDIT: Changed apparent typo in active_link_mask (#3195) * Update discord docs. (#3216) Co-authored-by: DavidMansolino <DavidMansolino@github.com> * Fix `test ros` on master (#3221) * apply same workflows * update agent version * revert restriction * missed some * again .. * Revert "update agent version" This reverts commit 2c7d9eb. * restore * revert it back again.. * Fix workflow * Update sources tests * Fix use of null variables (#3272) * Fixed MATLAB interface (#3297) * Fix texture URL in OSM importer (#3303) * Fix texture URL in OSM importer * Fix * fIX * Fix * Fix * PEP8 * PEP8 * fix link (#3314) * Fixed bad texture URL (#3306) * Fixed bad texture URLs (#3308) * Fixed bad texture URLs * Update building.py * Fixed discrepancy between guide and reference manual (#3315) * Adjust parameters (#3316) * Recommend for all users installation on Windows (#3317) * add missing (#3320) * Drop Python 2.7 (#3313) * Drop Python 2.7 * dropped references to Python 2.7 * Removed python 2.7 from distribution * Removed Python 2.7 * Remove Python 2.7 * Removed more occurences of Python 2.7 * More python2 removals * Fix shapely module error in `highway_driving_benchmark.wbt` (#3318) * check module import * remove blank line * Fix names in proto (#3325) * fix names * Update fabtino.meta.json (#3328) Remove webots:// in the .json file of the documentation Co-authored-by: Benjamin Délèze <benjamin.deleze@epfl.ch> * Fixed missing binary controller (#3334) * update distribution (#3335) * Fix nao room demo (#3323) * Fixed nao_room.wbt demo * fix background problem Co-authored-by: BenjaminDeleze <benjamin.deleze@epfl.ch> * Correction of Sick S300 Lidar parameters (#3319) * corrected parameters * typo * appearance * Add missing howto in docs (#3340) * missing howto docs * remove enu howto * fix * remove other references * Update docs/guide/samples-howto.md Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * remove language mention * fix link Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Update linux_optional_compilation_dependencies.sh (#3343) * Update linux_optional_compilation_dependencies.sh * Update linux_optional_compilation_dependencies.sh * Fix texture change controller (#3339) * Fixed texture_change controller * cleanup * Fixed script name, added comments * Recompile only C controllers in the /projects folder * replace default controller (#3338) * Fixed wren compilation warnings on Linux (#3344) * Fix MiR100 and Summit-XL Steel movement (#3341) * corrected mir * summit * mir x3d * pictures * fixed use def * Fixed GL_INVALID_OPERATION error in robot window (#3347) * fix (#3322) Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Fix pointlight reset (#3345) * Fix pointlight reset * add save * fix incorrect reset * changelog * fix night mode on windows (#3346) * Fix javascript construct (#3348) * Fix Javascript construct * Fixed javascript construct * add information about cache size used (#3342) * add information about cache size used * improve text * Update src/webots/gui/WbPreferencesDialog.cpp Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: ad-daniel <daniel.dias@epfl.ch> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> * Fix cabinet `primaryAppearance` (#3350) * debug * fix * fix (#3351) * Improve Urls handling (#3349) * expiration date (work only once) * fix expiration date * pause on loading * improve comment * Fixed Tinkerbots demos (#3356) * Fix nightly urls (#3359) * fix nightly urls * Update scripts/packaging/Makefile Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * replaced left by right (#3360) * Fix Cabinet doors and drawers physics (#3355) * removed first solid physics * Fixed world update test Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Added a warning when opening old worlds relying possibly on local resources (#3361) * Added a warning when opening old worlds relying possibly on local resources * Added a backward compatibility issue in the change log * Update changelog-r2021.md * Added precision * Cleanup useless/broken jquery includes (#3362) * Cleanup JQuery (#3363) * Reset scroll when changing tab in Robot Window (#3365) * reset scroll when changing tab * Update window_manager.js * Add instructions for force3d_sensor.wbt (#3366) * added info * Update force3d_sensor.wbt * Update projects/samples/devices/worlds/force3d_sensor.wbt Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Fix botstudio crash (#3364) * Fix relocation of Skins (#3368) * Fixed restart of Webots on Windows (#3367) * Fixed restart of Webots on Windows * change log * Fixed robot window javascript error on reset (#3370) * Fixed deletion of robot window on reset (Linux and macOS) (#3371) * Fixed deletion of robot window on reset * cleanup * Fix incorrect cleaning of WbLights (#3374) * debug * debug * debug * working * clean up * changelog * fix crash controllers (#3375) * fix crash controllers * fix-controller * Fix disabled proto test (#3373) * Fix disabled proto test * Display texture URL in error * Added more debug * Fixed texture URL * Fixed test tolerance * Fixed tests to display lua variants * Improved test suite scripts (#3378) * add warning for Safari (#3379) * Fix Guided Tour world canceling and switch causing crash (#3376) * debug * debug * debug * working * clean up * changelog * debug * cleanup * changelog * cleanup * cleanup * fix repo.txt when ssh (#3380) * Fix error in Lidar / RangeFinder measurement when hitting an edge (#3230) * solved issue * Update merge_spherical.frag * Update WbWrenCamera.cpp * clang * Update WbWrenShaders.cpp reclang * updated tests * Update range_finder_spherical_horizontal_vertical.c * Update range_finder_spherical_horizontal_vertical.c * clang * correct fovy * modified test * allow range of 2 pixels for range_finder_horizontal_vertical test * revert to original test * slightly biggest obstacle * revert to original test * tests with printf * get back to old test * get back to original test_suite.py * correct index * adapt range projection test * adapt range projection test * Improve python example (#3387) * Improved Python example * Clean-up * Added missing license header * cleanup * PEP8 * Stop sending requests to motor if goal is canceled (#3382) * Stop sending requests to motor if goal is canceled * Fix to follow PEP8 * Fixed P-Rob3 motor names (#3390) * Disable building of packages on develop (#3388) * Disable package creation on develop * postpone creation of package on develop until december * correct number of diff * Fix prob3 test (#3393) * Fix bug sumo (#3391) * Fix bug sumo * Update src/webots/nodes/utils/WbDownloader.cpp Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Reverts #3388 (#3399) * Update test_suite_linux_develop.yml * Update test_suite_mac_develop.yml * Update test_suite_windows_develop.yml * Update tests_sources.yml * Fix memory problem with Lidar point cloud (#3385) * try * removed wrong sizeof * cleanup * other approach * warning layer * clang * horizontal_res instead of width * corrections * corrections 2 * revert wbproj * revert wbproj * simplify * copy layers * Update src/webots/nodes/WbLidar.cpp Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Acquire the python GIL for all functions except Robot.step() (#3389) * Fix mac pythonpath (#3402) * inital work * fix typos * fix identation * better name for new functions * suppress false positive cpp check * cpp check * Update src/webots/control/WbLanguageTools.cpp Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Update src/webots/control/WbLanguageTools.cpp Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Update src/webots/control/WbLanguageTools.hpp Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * apply suggestions * cppcheck * Update changelog-r2021.md * Update changelog-r2021.md Co-authored-by: BenjaminDeleze <benjamin.deleze@infomaniak.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Sanitize controller name in MATLAB launcher (#3404) * Sanitize controller name, launch from temp file User-defined controllers may contain characters that MATLAB does not accept for scripts/function names, such as dashes. Use a temporary file for launching the controller, delete it afterwards. Thanks to @jgvictores for testing. See #3403. * Update changelog-r2021.md * Update changelog-r2021.md * Update changelog-r2021.md Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Fix `BallJoint` reset (#3394) * fix reset * add test * changelog * fix changelog and test * changelog * fix * cleanup * cleanup * undo * Update tests/physics/controllers/ball_joint_reset/ball_joint_reset.c Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Added Niryo Ned splash screen (#3408) * Added explanation about extern controllers and runtime.ini file (#3413) * Fix HighwaySign proto (#3407) * Fix HighwaySign proto * changelog * minor * solve thread hanging after webots process finishes (#3412) * solve thread hanging after webots process finishes * Update changelog-r2021.md * Fixed test Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Fixed issues with generic robot window (#3415) * Update documentation to avoid issues with generic robot window * Fixed automatic setting of PATH/LD_LIBRARY_PATH/DYLD_LIBRARY_PATH * Reverted documentation changes Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Adjust installation instructions for tarball (#3417) * Fix pen evaporation (#3416) * Fix pen evaporation * minor * fix clang * fix tests * Fix get_the_candies (#3431) * fix assets downloads on copy (#3428) * Remove restriction for Robotino from docs (#3432) Closes #3423. * Update tutorial-8-using-ros.md (#3433) * Update release date (#3437) * Update release date * Synch with webots_ros * Removed path to node.js and cleaned-up (#3427) * Add ROS and snap usage documentation (#3439) * Add ROS and snap usage documentation * Update tutorial-8-using-ros.md * Update tutorial-8-using-ros.md * Update tutorial-8-using-ros.md * Update tutorial-8-using-ros.md * Update docs/guide/tutorial-8-using-ros.md Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Update tutorial-8-using-ros.md Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Fix robot window linking with an external Python controller (#3449) * Fix robot window linking with an external Python controller * Fix docs * Update Makefile * Update running-extern-robot-controllers.md * Fix debug leftover in animation export (#3452) * fix debug leftover * Fixed cppcheck error * Fixed cppcheck error * Fixed cppcheck error * Fixed cppcheck error * Fixed clang_format* * reverted changes * Update LidarWidget.cpp Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Released in Master (#3455) * Update discord docs. (#3255) Co-authored-by: DavidMansolino <DavidMansolino@github.com> * Update discord docs. (#3369) Co-authored-by: DavidMansolino <DavidMansolino@github.com> * Update Discord Docs (#3418) * Update discord docs. * Removed obsolete test Co-authored-by: DavidMansolino <DavidMansolino@github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DavidMansolino <DavidMansolino@github.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * shape.md, appearance.md: link to PBRAppearance (#3453) * Fix typo in the doc (#3444) * Update appearance.md (#3454) * Update appearance.md * Update appearance.md * Update appearance.md Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> * Fix default url branch (#3458) * fix header version Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DavidMansolino <DavidMansolino@github.com> Co-authored-by: Darko Lukić <lukicdarkoo@gmail.com> Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com> Co-authored-by: Dorteel <dorteel@gmail.com> Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com> Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> Co-authored-by: Stefania Pedrazzi <stefania.pedrazzi@cyberbotics.com> Co-authored-by: Maël Wildi <mael18@windowslive.com> Co-authored-by: ad-daniel <daniel.dias@epfl.ch> Co-authored-by: sean85914 <sean19960914@gmail.com> Co-authored-by: BenjaminDeleze <benjamin.deleze@infomaniak.com> Co-authored-by: Bartek Łukawski <PeterBowman@users.noreply.github.com> Co-authored-by: Luiz Felipe Vecchietti <lfelipesv@kaist.ac.kr> Co-authored-by: Thomas Feldmeier <73528085+Thomas-Feldmeier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #3414:
Setting
LD_LIBRARY_PATHis needed also for python controllers in order to correctly load the generic robot window.The documentation was previously changed in #2940.