-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1219 from cyberark/bump-version-1.6.0
Bump version to 1.6.0
- Loading branch information
Showing
3 changed files
with
48 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,25 @@ | ||
#### What does this PR do (include background context, if relevant)? | ||
### What does this PR do? | ||
- _What's changed? Why were these changes made?_ | ||
- _How should the reviewer approach this PR, especially if manual tests are required?_ | ||
- _Are there relevant screenshots you can add to the PR description?_ | ||
|
||
#### What ticket does this PR close? | ||
### What ticket does this PR close? | ||
Connected to #[relevant GitHub issues, eg 76] | ||
|
||
#### Where should the reviewer start? | ||
### Checklists | ||
|
||
#### What is the status of the manual tests? | ||
Have you run the following manual tests to verify existing functionality continues to function as expected? | ||
- [ ] Manually tested [Keychain provider](https://github.com/cyberark/secretless-broker/tree/master/test/providers/keychain) | ||
- [ ] Manually run [Kubernetes-Conjur demo](https://github.com/conjurdemos/kubernetes-conjur-demo) with a local Secretless Broker image build of your branch | ||
|
||
If this feature does not have any/sufficent automated tests, have you created/updated a folder in `test/manual` that includes: | ||
- [ ] An updated README with instructions on how to manually test this feature | ||
- [ ] Utility `start` and `stop` scripts to spin up and tear down the test environments | ||
- [ ] A `test` script to run some basic manual tests (optional; if does not exist, the README should have detailed instructions) | ||
#### Change log | ||
- [ ] The CHANGELOG has been updated, or | ||
- [ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update | ||
|
||
#### Links to open issues for related automated integration and unit tests | ||
#### Test coverage | ||
- [ ] This PR includes new unit and integration tests to go with the code changes, or | ||
- [ ] The changes in this PR do not require tests | ||
|
||
#### Links to open issues for related documentation (in READMEs, docs, etc) | ||
#### Documentation | ||
- [ ] This PR does not require updating any documentation, or | ||
- [ ] Docs (e.g. `README`s) were updated in this PR, and/or there is a follow-on issue to update docs | ||
|
||
#### Screenshots (if appropriate) | ||
#### (For releases only) Manual tests | ||
- [ ] Manually tested [Keychain provider](https://github.com/cyberark/secretless-broker/tree/master/test/providers/keychain) | ||
- [ ] Manually run [Kubernetes-Conjur demo](https://github.com/conjurdemos/kubernetes-conjur-demo) with a local Secretless Broker image build of your branch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters