Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin openapitools/openapi-generator-cli version #228

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Unpin openapitools/openapi-generator-cli version #228

wants to merge 8 commits into from

Conversation

john-odonnell
Copy link
Contributor

Desired Outcome

Please describe the desired outcome for this PR. Said another way, what was
the original request that resulted in these code changes? Feel free to copy
this information from the connected issue.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell
Assorted description updates
10387d4 
- Update createSecret requests to require a non-empty body
- Removed redundant types resources/schemas/Resources and
  host-factory/schemas/CreateHostToken
- Fix API key length requirement
@john-odonnell
Unpin OpenAPI Generator CLI version
6166857 
- Remove outdated Python templates
- Update Python example
- Update Python integration tests
@john-odonnell
Add default Python API client template
78a9258
@john-odonnell
Bug workaround: dereference Enum type path parameters
962aef6 
See OpenAPITools/openapi-generator#16688
@john-odonnell
Use byte-types for secret creation and retrieval
9288798 
Conjur's secrets/ endpoints expect binary data by default. See:
- "Binary" type request body expected when setting a secret
  https://docs.conjur.org/Latest/en/Content/Developer/Conjur_API_Set_Secret.htm?tocpath=Developer%7CREST%C2%A0APIs%7C_____7#RequestBody
- application/octet-stream Content-Type response expected on
  successful secret retrival:
  https://docs.conjur.org/Latest/en/Content/Developer/Conjur_API_Retrieve_Secret.htm?tocpath=Developer%7CREST%C2%A0APIs%7C_____8#Response200
@john-odonnell
Update Ruby example for Generator version bump
31548cd
@john-odonnell
Update C# client tests for Generator version bump
ef53014
@john-odonnell
CONTRIB: fix cmd for running only specific test case
f451192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@john-odonnell