Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overflow #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow overflow #42

wants to merge 1 commit into from

Conversation

sdrapha
Copy link

@sdrapha sdrapha commented May 12, 2022 •
edited
Loading

Allow overflow to fix issue #40

@sdrapha
Allow overflow to fix issue custom-cards#40
551c0bc 
Allow overflow to fix issue custom-cards#40 

Honestly I'm doing this pull request straight from github, without testing it.  
I have more experience on backend stuff and python, not much in the frontend or typescript. I would have to learn and figure out how to test it. And  I plan to do, WHEN I have more time, but meanwhile this guesswork change looks like the correct thing to do based in the workaround posted. 
If someone can also review or test it I apreciate.!
@sdrapha
Copy link
Author

sdrapha commented May 23, 2022

I was finally able to test it. It works! And I didn't notice any side effect. It should be fine for merging.

@sdrapha sdrapha changed the title Allow overflow to fix issue #40 Allow overflow May 24, 2022
@Kalitsune
Copy link

Kalitsune commented Jan 2, 2024 •
edited
Loading

I hope it'll be merged someday

It's not maintained anymore though so it probably will never happen

@Kalitsune
Copy link

for those of you seeking to fix the issue despite the PR not being merged you can use card mod:
just add this to your yaml:

card_mod:
    style: 'ha-card {overflow: visible !important}'

you can also check #47 if you seek to remove the borders inside the card.

ildar170975
ildar170975 reviewed Jan 9, 2024
View reviewed changes
Copy link

@ildar170975 ildar170975 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better:

    ha-card {
      overflow: visible;
    }
    ha-card > div {
      overflow-x: clip;
    }

But clip value may not work in some old browsers.

stickpin added a commit to stickpin/stack-in-card that referenced this pull request Mar 9, 2024
@stickpin
Allow overflow fix by @sdrapha
f492224 
custom-cards#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildar170975 ildar170975 ildar170975 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdrapha @Kalitsune @ildar170975