Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(styles): use logical operators where possible #5345

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Dec 3, 2024

What and Why

Refactor styles to remove the usage of [dir="rtl"] & to resolve these warnings in the Storybook build.
image

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: d87aa6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 10ffcee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@mcwinter07 mcwinter07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some nice clean up there

padding-right: 1.75rem;
padding-left: $button-base-padding-horizontal;
}
padding-inline: 1.75rem $button-base-padding-horizontal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

}

@mixin ca-type-align-end() {
text-align: right; // fallback for IE and Edge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehehe nice find

@HeartSquared HeartSquared marked this pull request as ready for review December 3, 2024 06:27
@HeartSquared HeartSquared requested a review from a team as a code owner December 3, 2024 06:27
Copy link
Contributor

github-actions bot commented Dec 3, 2024

✨ Here is your branch preview! ✨

Last updated for commit d87aa6d: Merge branch 'main' into heartsquared/refactor-deprecated-styles

@HeartSquared HeartSquared merged commit 2760617 into main Dec 3, 2024
22 checks passed
@HeartSquared HeartSquared deleted the heartsquared/refactor-deprecated-styles branch December 3, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants