Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translate TaskRunner #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: translate TaskRunner #1

wants to merge 7 commits into from
+1,015 −91

Commits on Dec 3, 2024

  1. chore: init go project

    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    50a100f View commit details
    Browse the repository at this point in the history

  2. feat: add TaskRunner code 

    This change is a naive golang translation of the `TaskRunner` code from
Murmur (refer to notes). The aim of this commit is to get the initial
code into the repo and start building on it from there.

Notes:
- TaskRunner permalink: https://github.com/cultureamp/murmur/blob/260f8936d59aaa6074c6fc6f31b935e011bda9f6/ops/migrations-runner/lib/TaskRunner.ts
- migrations-runner permalink: https://github.com/cultureamp/murmur/tree/078d0154b1215f226df5d3d081dfd131a8ae898a/ops/migrations-runner
    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6032330 View commit details
    Browse the repository at this point in the history

  3. refactor: describeTask is redundant while we assume a single task is … 

    …returned
    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    cd165a6 View commit details
    Browse the repository at this point in the history

  4. feat: plugin.RUN is the entrypoint of the business logic

    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f80558f View commit details
    Browse the repository at this point in the history

  5. refactor: plugin is named task-runner

    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    307ed57 View commit details
    Browse the repository at this point in the history

  6. test(plugin): mocks have a pre-existing shared directory

    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    4b1aab3 View commit details
    Browse the repository at this point in the history

  7. chore: gci doesn't bring value to linting 

    The value to have deterministic import orders in our code doesn't seem
that useful considering that imports will automatically be cleaned up
and sorted thanks to the native tooling. This should be good enough
without another opinionated tool complaining that the order isn't _that_
specific way. It's low-impact, and not worth having 2 toolings fight
over this.
    @therealvio
    therealvio committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    ba7806d View commit details
    Browse the repository at this point in the history