Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation support #665

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Localisation support #665

merged 2 commits into from
Nov 14, 2024

Conversation

MegaGrindStone
Copy link
Contributor

🤔 What's changed?

Added Dialect option to switch between language for the feature file.

⚡️ What's your motivation?

New feature - Resolves #663

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (153db4e) to head (ae6d4e9).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   83.21%   79.82%   -3.39%     
==========================================
  Files          28       41      +13     
  Lines        3413     4050     +637     
==========================================
+ Hits         2840     3233     +393     
- Misses        458      697     +239     
- Partials      115      120       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vearutop vearutop merged commit da4633a into cucumber:main Nov 14, 2024
6 of 7 checks passed
@vearutop
Copy link
Member

Thank you, looks good!

@MegaGrindStone MegaGrindStone deleted the localisation branch November 14, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localisation supports
2 participants