feat: add optional error codes to networkError
#384
+183
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerkinDev
force-pushed
the
feat/node-errors
branch
from
d0a2760
to
cfe6b11
Compare
|
FYI I rebased it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #365
The expected bundle size seems very constraining, and I did not find a way to reduce it below 3Kb without impacting readability or doing deeper reconf/refactoring.
Also, I had issues installing the dev dependencies since I'm using node 20 and
bundlesizerelies onbrotli-size@0.1.0which in turn relies oniltorb@^2.4.3that is deprecated and using legacy node-gyp headers. Somehow, I fixed it locally, but specifying the node version you use either in the readme or in an.nvmrcfile would have helped.