Update to run multiple instances of same webdriver #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r on different port
Dakad
commented
May 5, 2023
| driver1.try &.stop | ||
| session2.try &.delete | ||
| driver2.try &.stop | ||
| TestServer.reset |
There was a problem hiding this comment.
I encountered this error after running the specs. The TestServer port remains open after the test.
It doesn't happen all the time though.
Dakad
added a commit
to Dakad/webdriver_pump
that referenced
this pull request
May 6, 2023
To use the fix for crystal-loot/selenium.cr#30
Dakad
added a commit
to Dakad/webdriver_pump
that referenced
this pull request
May 6, 2023
To use the fix for crystal-loot/selenium.cr#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Description
This PR is a fix for #21 and an attempt to resolve #24.
This PR changes update the
Service.startto check if the default port assigned to the browser service is available or not.If not, it will keep increasing the port number until we found an open port and use it to run the driver bin command
This will change will allow multiple instances to run the same browser on different ports, each one with its own context/session. It's very helpful when using Fiber 🎉
How it was tested?
Locally by running
SELENIUM_BROWSER=firefox crystal spec -DDEBUG --error-trace spec/features/session_spec.cr