Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bouncycastle artifacts are not included in build jar #48

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

infeo
Copy link
Member

@infeo infeo commented Apr 15, 2024

Fixes #47.

Summary by CodeRabbit

  • Chores
    • Updated the artifact version in the project configuration to enhance compatibility and security.

@infeo infeo added this to the 1.5.2 milestone Apr 15, 2024
Copy link

coderabbitai bot commented Apr 15, 2024

Walkthrough

The update in the pom.xml file primarily focuses on upgrading the Bouncy Castle dependency from bcprov-jdk15on to bcprov-jdk18on. This change aims to resolve compatibility issues highlighted by a NoClassDefFoundError during testing, indicating a problem with the handling of dependencies in the project's configuration.

Changes

File Change Summary
pom.xml Updated Bouncy Castle version from jdk15on to jdk18on

Assessment against linked issues

Objective (Issue Number) Addressed Explanation
Exception handling for java.lang.NoClassDefFoundError related to Bouncy Castle dependency (#47)

🐇🌟
A hop, a skip, a version jump,
From 15on to 18, what a bump!
No more errors, no more fright,
Bouncy Castle now feels just right.
Cheers to code that runs so smooth,
With every test, we improve and prove! 🎉
🐇🌟


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between fc85711 and 1823923.
Files selected for processing (1)
  • pom.xml (2 hunks)
Additional comments not posted (2)
pom.xml (2)

227-227: Update to include bcprov-jdk18on in the shaded jar is correct and aligns with the PR objectives.


238-238: Exclusion of META-INF/** for bcprov-jdk18on is appropriate to avoid potential conflicts in the shaded jar.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@infeo infeo merged commit 4f602ed into develop Apr 16, 2024
5 checks passed
@infeo infeo deleted the feature/47-shade-correct-artifact branch April 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception java.lang.NoClassDefFoundError: org/cryptomator/siv/org/bouncycastle/crypto/BlockCipher
2 participants