Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi: Update implementation of dex dcr Wallet interface #568

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ukane-philemon
Copy link
Collaborator

This PR updates the "replace" dex package to use changes in decred/dcrdex#2855 cuz it is more up to date and fixes a concurrent map write bug that came up during testing a6c7153.


2024-07-09 14:45:37.928 [INF] LTC: Current sync progress update is on block 2498000, target sync block is 3344058
2024-07-09 14:45:38.788 [INF] BTC: Current sync progress update is on block 2837000, target sync block is 2867061
2024-07-09 14:45:40.026 [INF] LTC: Processed 578 blocks in the last 10.03s (height 2500314, 2022-09-05 01:49:48 +0100 WAT)
fatal error: concurrent map writes

goroutine 20256 [running]:
github.com/crypto-power/cryptopower/ui/page/components.(*WalletSyncInfo).ListenForNotifications.func1({{0xc00b6a4d96?, 0x0?}, 0x7000102?, 0x0?, 0x0?})
        /Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_sync_info.go:551 +0xd2
github.com/crypto-power/cryptopower/ui/page/components.(*WalletSyncInfo).ListenForNotifications.func3(0xc0018eae78)
        /Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_sync_info.go:573 +0x55
github.com/crypto-power/cryptopower/libwallet/assets/dcr.(*Asset).publishAddressDiscoveryProgress(0xc000172240)
        /Users/philemon/Desktop/osp/cryptopower/libwallet/assets/dcr/syncnotification.go:396 +0x5b
github.com/crypto-power/cryptopower/libwallet/assets/dcr.(*Asset).updateAddressDiscoveryProgress(0xc000172240, 0x4062c00000000000)
        /Users/philemon/Desktop/osp/cryptopower/libwallet/assets/dcr/syncnotification.go:377 +0x579
created by github.com/crypto-power/cryptopower/libwallet/assets/dcr.(*Asset).discoverAddressesStarted in goroutine 772
        /Users/philemon/Desktop/osp/cryptopower/libwallet/assets/dcr/syncnotification.go:303 +0x1ca

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@dreacot dreacot merged commit 311bff9 into crypto-power:master Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants