Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binary build workflow #345

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

dreacot
Copy link
Member

@dreacot dreacot commented Dec 20, 2023

No description provided.

@dreacot dreacot marked this pull request as ready for review December 20, 2023 01:28
Comment on lines +1 to +7
name: Cross-Platform Build on New Tag

on:
pull_request:
push:
tags:
- '*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it runs on PRs too, not just tags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i added the pr trigger there, so I wouldn't have to be creating and deleting tags, plus so i can test without merging, once i get all binaries building successfully i’d remove the pr trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants