Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update ci workflow #171

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Nov 20, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #172

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@aali309 aali309 added chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 20, 2023
@andrewazores
Copy link
Member

I think this step failure is probably related to https://github.com/cryostatio/cryostat/issues/1783 as well:

https://github.com/cryostatio/cryostat3/actions/runs/6935739877/job/18866498335?pr=171

though I'm not sure exactly how/why.

@aali309
Copy link
Contributor Author

aali309 commented Nov 20, 2023

I was about to ask. I think I need to add permissions on every job

@andrewazores andrewazores merged commit c4f8511 into cryostatio:main Nov 20, 2023
5 of 6 checks passed
@aali309 aali309 deleted the updateCiWorkflow branch March 7, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Meta] CI workflows must request write permission
2 participants