Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rename): update references after repo rename #918

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to cryostatio/cryostat#555
Related to cryostatio/cryostat-helm#159

Description of the change:

This change adds allows the users to provide...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Insert steps here...
  2. ...

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Jul 15, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores requested a review from ebaron July 15, 2024 17:17
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this would cause any problems when upgrading?

@andrewazores
Copy link
Member Author

I imagine that it will break things on upgrade, but the next version is already likely to break things on upgrade anyway since we're scoping in work like cryostatio/cryostat#549 and #814 . I'm hoping that putting all those pieces together in the next release means that we can have a better migration/upgrade path from that point on.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@andrewazores andrewazores merged commit c7ccef4 into cryostatio:main Jul 15, 2024
7 checks passed
@andrewazores andrewazores deleted the repo-rename branch July 15, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants