feat(api): add ExternalHost property for routes #877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit -S -m "YOUR_COMMIT_MESSAGE"
Fixes: #726
Description of the change:
spec.networkOptions.coreConfig.externalHost
to the Cryostat v1beta2 CRD.spec.host
is immutable once created. I had considered some logic to recreate the route if the user attempts to change the host in the CR, but this is further complicated due to OpenShift modifying thespec.host
field in the default case where it dynamically assigns a hostname. I think trying to accommodate this is too risky for 3.0.Motivation for the change:
How to manually test:
spec.networkOptions.coreConfig.externalHost
defined to a custom value.