Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): add short summaries to targets #637

Merged
merged 28 commits into from
Oct 3, 2023
Merged

chore(build): add short summaries to targets #637

merged 28 commits into from
Oct 3, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Sep 29, 2023 •
edited
Loading

See #636
Fixes #634

I used the git reflog and attempted to cherry-pick the correct changes back together after failing to properly rebase @pektezol 's previous PR. This PR is a backup in case the original one cannot be fully recovered.

pektezol and others added 26 commits September 29, 2023 11:27
@pektezol @andrewazores
feat(build): add short summaries to targets
cd4dc31 
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
Update Makefile
41ce261 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
Update Makefile
189f96a 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @andrewazores
Explain podman MANIFEST_PUSH
5b1acb9 
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
controller-gen
1220283 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
controller-gen
a3dd02c 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @andrewazores
catalog-build
f4593bd 
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
cert_manager
930c428 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
undeploy_sample_app_agent
e79163b 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
sample_app_agent
79530b0 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
sample_app
fcb0211 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
check-license
b284bd3 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
install
8bbb666 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
uninstall
bd47503 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
deploy
faa0469 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @andrewazores
predeploy
1db0137 
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
undeploy
a2e29cd 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
print_deploy_config
69438c7 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
deploy_bundle
581eaac 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
undeploy_bundle
bf6af4d 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
create_cryostat_cr
f2e31bd 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
destroy_cryostat_cr
29c52cb 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
destroy_clustercryostat_cr
5f9d5bc 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @andrewazores
create_clustercryostat_cr
001a0c0 
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @tthvo @andrewazores
help
afa27fb 
Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@pektezol @andrewazores
destroy_clustercryostat_cr
edbc129 
Co-authored-by: Andrew Azores <me@andrewazor.es>
Signed-off-by: Arda Serdar Pektezol <1669855+pektezol@users.noreply.github.com>
@mergify mergify bot added the safe-to-test label Sep 29, 2023
@andrewazores
Copy link
Member Author

@pektezol @tthvo sorry about that. If @pektezol 's original PR can't be recovered and reopened easily then please double-check my work attempting to recover it here.

tthvo
tthvo approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think we can move the work to this PR then to ease the recover process.

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Sep 29, 2023
@tthvo tthvo added the build label Sep 29, 2023
@tthvo tthvo mentioned this pull request Sep 29, 2023
Closed
7 tasks
@andrewazores andrewazores marked this pull request as ready for review September 29, 2023 19:04
@tthvo
Copy link
Member

tthvo commented Sep 29, 2023

Maybe also link #634 to automatically close it?

@pektezol
Copy link
Contributor

Damn what happened here lol. Oh well.

@pektezol
Copy link
Contributor

pektezol commented Oct 2, 2023

Any update on this pr? @tthvo

@andrewazores
Copy link
Member Author

It looks good to me (and @tthvo too I think), but I tagged @ebaron for review since he's the primary maintainer of this repository. He's been busy with other tasks in the meantime.

ebaron
ebaron approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks @pektezol!

@ebaron ebaron merged commit 81a32e9 into cryostatio:main Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
build chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Makefile should have short summaries for targets
4 participants
@andrewazores @tthvo @pektezol @ebaron