Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Allow to configure the custom routes domain for cryostat and grafana #726

Closed
ippul opened this issue Feb 13, 2024 · 2 comments · Fixed by #877
Closed

[Bug] Allow to configure the custom routes domain for cryostat and grafana #726

ippul opened this issue Feb 13, 2024 · 2 comments · Fixed by #877
Labels
feat New feature or request user report

Comments

@ippul
Copy link

ippul commented Feb 13, 2024

Current Behavior

When Cryostat is deployed using operator, the route host contains the openshift domain({instance-name}-{namespace-name}.{opc-instance-domain}) and is not possible to customise it using via CR
Cryostat container stores the grafana routes in an enviroment variable named GRAFANA_DASHBOARD_EXT_URL so manually create the routes is not a suitable workaround

Expected Behavior

Allow to customise the route domain using CR

Steps To Reproduce

Create the custom resource

cat > my-app-cryostat.yaml << EOL
apiVersion: operator.cryostat.io/v1beta1 
kind: ClusterCryostat 
metadata: 
  name: my-app-cryostat
spec: 
  enableCertManager: true 
  installNamespace: cryostat-examples 
  minimal: false 
  reportOptions: 
    replicas: 1 
    resources: 
      limits: 
        cpu: '1' 
        memory: 1Gi 
      requests: 
        cpu: 500m 
        memory: 512Mi 
  resources: 
    coreResources: 
      limits: 
        cpu: '1' 
        memory: 2Gi 
      requests: 
        cpu: 500m 
        memory: 1Gi 
    dataSourceResources: 
      limits: 
        cpu: 500m 
        memory: 256Mi 
      requests: 
        memory: 256Mi 
    grafanaResources: 
      limits: 
        cpu: 500m 
        memory: 256Mi 
      requests: 
        memory: 256Mi 
  storageOptions: 
    pvc: 
      spec:
        resources: {} 
  targetDiscoveryOptions: 
    builtInDiscoveryDisabled: true 
EOL    

Apply the custom resource
oc apply -f my-app-cryostat.yaml

Verify the routes are in the format {instance-name}-{namespace-name}.{opc-instance-domain}
oc get routes

Check that the Cryostat container define an environment variable named "GRAFANA_DASHBOARD_EXT_URL" and value the route of the grafana instance

Environment

- OS: 
- Environment: 
- Version:

Anything else?

No response

@ippul ippul added bug Something isn't working needs-triage Needs thorough attention from code reviewers labels Feb 13, 2024
@andrewazores
Copy link
Member

Related to cryostatio/cryostat#262

@andrewazores andrewazores added feat New feature or request user report and removed bug Something isn't working needs-triage Needs thorough attention from code reviewers labels Feb 13, 2024
@andrewazores andrewazores moved this to Stretch Goals in 3.0.0 release Feb 13, 2024
@andrewazores
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request user report
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants