Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pom): upgrade vert-x from 4.4.4 to 4.4.9 (backport #1913) #1916

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 22, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

This is an automatic backport of pull request #1913 done by [Mergify](https://mergify.com).

* chore(pom): upgrade vertx from 4.4.4 to 4.4.9

* fix test mockito specifications for new overload

* upgrade netty

(cherry picked from commit b2e0c30)
@ebaron
Copy link
Member

ebaron commented Apr 22, 2024

/build_test

Copy link
Contributor

Workflow started at 4/22/2024, 6:29:17 PM. View Actions Run.

Copy link
Contributor

Hi @mergify[bot]! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 22, 2024
Copy link
Contributor

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores
Copy link
Member

Bah... the old CI setup for pulling from GH pkgs has already been removed from the repo/org in favour of pulling from (unauthenticated) Maven Central. But, the old version of -core needed for the 2.4 branch isn't on Central.

@ebaron ebaron added chore Refactor, rename, cleanup, etc. and removed needs-triage Needs thorough attention from code reviewers labels Apr 22, 2024
@ebaron ebaron merged commit 73d70f3 into cryostat-v2.4 Apr 22, 2024
12 of 13 checks passed
@mergify mergify bot deleted the mergify/bp/cryostat-v2.4/pr-1913 branch April 22, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants