Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): Endpoints discovery port names/numbers are configurable (backport #1862) #1874

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 12, 2024

This is an automatic backport of pull request #1862 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link
Contributor

Hi @mergify[bot]! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Feb 12, 2024
@andrewazores andrewazores added fix safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Feb 12, 2024
@andrewazores
Copy link
Member

/build_test

Copy link
Contributor

Workflow started at 2/12/2024, 2:32:40 PM. View Actions Run.

Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1874-6e32f68ce55add15da84550840bbe883ce816391-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1874-6e32f68ce55add15da84550840bbe883ce816391-linux-arm64

To run smoketest:

# amd64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1874-6e32f68ce55add15da84550840bbe883ce816391-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1874-6e32f68ce55add15da84550840bbe883ce816391-linux-arm64 sh smoketest.sh

Copy link
Contributor

/build_test : At least one test failed ❌.
View Actions Run.

@andrewazores
Copy link
Member

Failed because the requested -core version wasn't downloadable by CI. Annoying. Testing locally instead.

@andrewazores andrewazores merged commit bf58882 into cryostat-v2.4 Feb 12, 2024
14 of 15 checks passed
@mergify mergify bot deleted the mergify/bp/cryostat-v2.4/pr-1862 branch February 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant