Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): build_test command enhancements #1683

Merged
merged 22 commits into from
Oct 30, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Sep 22, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #1634

Description of the change:

  • Leave a comment of the Actions run when it starts
  • Leave a comment noting whether the tests passed or failed
  • Retry integration test by typing /retest to simply rerun the tests without a rebuild

Motivation for the change:

provide enhancements to the existing command /build_test

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@aali309 aali309 added the feat New feature or request label Sep 22, 2023
@mergify mergify bot added the safe-to-test label Sep 22, 2023
@aali309
Copy link
Contributor Author

aali309 commented Sep 22, 2023

/build_test

@github-actions
Copy link
Contributor

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat:pr-1683-a2fb59056f0f2b74253220040c6fd29ee71b940f-linux-amd64
arm64 ghcr.io/cryostatio/cryostat:pr-1683-a2fb59056f0f2b74253220040c6fd29ee71b940f-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1683-a2fb59056f0f2b74253220040c6fd29ee71b940f-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1683-a2fb59056f0f2b74253220040c6fd29ee71b940f-linux-arm64 sh smoketest.sh

@aali309 aali309 marked this pull request as ready for review September 22, 2023 18:20
@mwangggg
Copy link
Member

do you have a demo we can take a look at?

@aali309
Copy link
Contributor Author

aali309 commented Sep 26, 2023

do you have a demo we can take a look at?

Couldn't run a demo yesterday because of the missing logic on if[...]. should do it today, I have no pending issues

@mwangggg
Copy link
Member

mwangggg commented Sep 29, 2023

cryostatio/cryostat-core#266 (comment) - following this discussion, could you remove the permissions in the ci-build-image.yml file too?

@aali309
Copy link
Contributor Author

aali309 commented Oct 4, 2023

https://github.com/aali309/cryostat/actions/runs/6410504392/job/17403950446.. This is a demo run.. will need help to tackle this where /retest does not build images but just runs the integrated tests only.

@aali309 aali309 added the help wanted Extra attention is needed label Oct 4, 2023
@aali309
Copy link
Contributor Author

aali309 commented Oct 11, 2023

https://github.com/aali309/cryostat/actions/runs/6474602388/job/17579876114 sample run with the update

@aali309 aali309 marked this pull request as draft October 11, 2023 13:04
@aali309 aali309 marked this pull request as ready for review October 13, 2023 21:03
@aali309
Copy link
Contributor Author

aali309 commented Oct 13, 2023

/request_review

@aali309
Copy link
Contributor Author

aali309 commented Oct 13, 2023

Sample run:

/retest https://github.com/aali309/cryostat/actions/runs/6512927455

image

image

/build-test https://github.com/aali309/cryostat/actions/runs/6512926521

image

image

@aali309
Copy link
Contributor Author

aali309 commented Oct 13, 2023

sample run after extra conditions https://github.com/aali309/cryostat/actions/runs/6513631944/job/17693607675

@aali309
Copy link
Contributor Author

aali309 commented Oct 26, 2023

Added the test failure message as well & intentionally failed the test to see sample run
PR LINK: https://github.com/aali309/cryostat/pull/112
/retest failure LINK: https://github.com/aali309/cryostat/actions/runs/6659054066

image

image

WITH ALL TESTs passing LINK: https://github.com/aali309/cryostat/actions/runs/6659291198

@andrewazores
Copy link
Member

Very nice, that looks like it's working really well. I still had those two comments before - one small question and one small refactor/cleanup suggestion. Anyone else have any review feedback? I think this is really close to being done and ready for merge.

@andrewazores andrewazores merged commit d380aa9 into cryostatio:main Oct 30, 2023
8 checks passed
@aali309 aali309 deleted the build_testCommand branch October 30, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] /build_test command enhancements
4 participants