Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): apply resource constraints matching operator deployment defaults #1615

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 17, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to https://github.com/cryostatio/cryostat/issues/1329

Description of the change:

This sets --cpu and --memory flags on Cryostat component containers that match the defaults the -operator sets if the user does not provide overriding configurations.

Motivation for the change:

With this configuration, we can get a better sense of what the resource requirements are for the various containers within one of the shorter development loops.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. Test general functionality and ensure things still work. They will probably be much slower with this configuration - perhaps we need to raise some defaults.

@github-actions github-actions bot added dependent needs-triage Needs thorough attention from code reviewers labels Aug 17, 2023
@mergify mergify bot added the safe-to-test label Aug 17, 2023
@andrewazores andrewazores added dependent test and removed needs-triage Needs thorough attention from code reviewers labels Aug 17, 2023
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-c9cb6f9e980678ea68f851d627b5dc356b74edf1-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-c9cb6f9e980678ea68f851d627b5dc356b74edf1-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-c9cb6f9e980678ea68f851d627b5dc356b74edf1-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-c9cb6f9e980678ea68f851d627b5dc356b74edf1-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-0cae9111c82db16d9c0d4d3bb9712c599a026e79-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-0cae9111c82db16d9c0d4d3bb9712c599a026e79-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-0cae9111c82db16d9c0d4d3bb9712c599a026e79-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1615-0cae9111c82db16d9c0d4d3bb9712c599a026e79-linux-amd64 sh smoketest.sh

@andrewazores andrewazores merged commit 8023d71 into cryostatio:main Aug 23, 2023
19 checks passed
@andrewazores andrewazores deleted the resource-constrained-smoketest branch August 23, 2023 00:11
andrewazores added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants