-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(smoketest): apply resource constraints matching operator deployment defaults #1615
Merged
andrewazores
merged 1 commit into
cryostatio:main
from
andrewazores:resource-constrained-smoketest
Aug 23, 2023
Merged
test(smoketest): apply resource constraints matching operator deployment defaults #1615
andrewazores
merged 1 commit into
cryostatio:main
from
andrewazores:resource-constrained-smoketest
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependent
needs-triage
Needs thorough attention from code reviewers
labels
Aug 17, 2023
andrewazores
force-pushed
the
resource-constrained-smoketest
branch
from
August 17, 2023 16:42
a0b74fe
to
0a67fb1
Compare
andrewazores
added
dependent
test
and removed
needs-triage
Needs thorough attention from code reviewers
labels
Aug 17, 2023
andrewazores
force-pushed
the
resource-constrained-smoketest
branch
from
August 17, 2023 16:44
0a67fb1
to
c9cb6f9
Compare
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
ebaron
approved these changes
Aug 22, 2023
andrewazores
force-pushed
the
resource-constrained-smoketest
branch
from
August 22, 2023 20:32
c9cb6f9
to
0cae911
Compare
Test image available:
|
Test image available:
|
Test image available:
|
Test image available:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to https://github.com/cryostatio/cryostat/issues/1329
Description of the change:
This sets
--cpu
and--memory
flags on Cryostat component containers that match the defaults the-operator
sets if the user does not provide overriding configurations.Motivation for the change:
With this configuration, we can get a better sense of what the resource requirements are for the various containers within one of the shorter development loops.
How to manually test: